Web编程 订阅所有【Web编程】的日志

VS2008对引发异常和再次引发捕获异常的建议

编辑:dnawo 日期:2009-04-22

字体大小: 小 中 大
复制内容到剪贴板程序代码 程序代码
using System;
using System.Collections.Generic;
using System.Text;
using System.IO;
using System.Diagnostics;

namespace ClassLibrary1
{
    public class CommandLine
    {
        public static string Call(string name, params string[] args)
        {
            string returnValue = "";

            if (args.Length == 0)
                throw new Exception("缺少命令行参数！");

            using (Process commandline = new Process())
            {
                try
                {
                    commandline.StartInfo.UseShellExecute = false;
                    commandline.StartInfo.CreateNoWindow = true;
                    commandline.StartInfo.WindowStyle = ProcessWindowStyle.Hidden;
                    commandline.StartInfo.RedirectStandardOutput = true;
                    commandline.StartInfo.FileName = name;
                    //commandline.StartInfo.WorkingDirectory = "";
                    commandline.StartInfo.Arguments = "";
                    //添加命令行参数
                    for (int i = 0; i < args.Length; i++)
                    {
                        commandline.StartInfo.Arguments += string.Format("\"{0}\" ", args[i]);//加引号防止参数带空格时出错
                    }

                    commandline.Start();
                    returnValue = commandline.StandardOutput.ReadToEnd().ToLower();
                    commandline.WaitForExit();
                    commandline.Close();
                }
                catch (Exception ex)
                {
                    commandline.Dispose();
                    throw ex;
                }
            }

            return returnValue;
        }
    }
}

运行代码分析后收到如下警告：

引用内容 引用内容
警告    4    CA2201 : Microsoft.Usage : 'CommandLine.Call(string, params string[])' 创建类型为 'Exception' 的异常，该异常类型不够具体，不应由用户代码引发。如有可能引发此异常实例，请使用其他异常类型。    E:\www\Demo\ClassLibrary1\CommandLine.cs    29    ClassLibrary1
警告    5    CA2200 : Microsoft.Usage : 'CommandLine.Call(string, params string[])' 再次引发捕获的异常并将其显式地指定为一个参数。请改用不带参数的“throw”以保留该异常最初引发时所在的堆栈位置。    E:\www\Demo\ClassLibrary1\CommandLine.cs    53    ClassLibrary1

修改如下(红色部分)：

复制内容到剪贴板程序代码 程序代码
using System;
using System.Collections.Generic;
using System.Text;
using System.IO;
using System.Diagnostics;

namespace ClassLibrary1
{
    public class CommandLine
    {
        public static string Call(string name, params string[] args)
        {
            string returnValue = "";

            if (args.Length == 0)
                throw new ArgumentException("缺少命令行参数！");

            using (Process commandline = new Process())
            {
                try
                {
                    commandline.StartInfo.UseShellExecute = false;
                    commandline.StartInfo.CreateNoWindow = true;
                    commandline.StartInfo.WindowStyle = ProcessWindowStyle.Hidden;
                    commandline.StartInfo.RedirectStandardOutput = true;
                    commandline.StartInfo.FileName = name;
                    //commandline.StartInfo.WorkingDirectory = "";
                    commandline.StartInfo.Arguments = "";
                    //添加命令行参数
                    for (int i = 0; i < args.Length; i++)
                    {
                        commandline.StartInfo.Arguments += string.Format("\"{0}\" ", args[i]);//加引号防止参数带空格时出错
                    }

                    commandline.Start();
                    returnValue = commandline.StandardOutput.ReadToEnd().ToLower();
                    commandline.WaitForExit();
                    commandline.Close();
                }
                catch
                {
                    commandline.Dispose();
                    throw;
                }
            }

            return returnValue;
        }
    }
}

建议：有时间多运行下代码分析工具，VS会给你一些很有用的建议，再针对这些建议对代码进行修改，这样能提高代码的整体性能。

上一篇: C#读取WinRAR安装路径
下一篇: 新云允许链接本站的域名设置失效分析
文章来自: 本站原创
引用通告: 查看所有引用 | 我要引用此文章
Tags:
最新日志:
评论: 0 | 引用: 0 | 查看次数: 7498
发表评论
请登录后再发表评论！